Clarify group algorithm constraints #730
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes two clarifications: - When an algorithm accepts a pointer, it can be a multi_ptr; and - When an algorithm accepts a value, it can be a vec or marray. A list of types compatible with group algorithms is removed in favor of listing the types explicitly for each algorithm, since some algorithms have different constraints.
This note had been duplicated for group functions and group algorithms. The note about group algorithms was removed in a previous commit.
Contributor
|
Look good, but should CTS but updated? |
TApplencourt
approved these changes
Feb 20, 2025
gmlueck
reviewed
Mar 2, 2025
Contributor
|
Blocked by #765 |
gmlueck
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes three clarifications:
multi_ptr;vecormarray;sycl::half.A list of types compatible with group algorithms is removed in favor of listing the types explicitly for each algorithm, since some algorithms have different constraints (e.g., some algorithms support all trivially copyable types).
Closes #340 and closes #461.
Two other things to note here...
I deliberately didn't add
__swizzle__, because I don't think that was part of our original intent. We could explore this as an extension, but adding the overloads for__swizzle__is non-trivial; the return type would have to be different (i.e.,vec), and I don't think existing implementations actually support this case.I realize that the group algorithms section is now really long and repetitive, but my goal with this PR is simply to fix the wording. The section would definitely benefit from another formatting and consolidation pass. Defining a term that means "C++ fundamental type,
half,marrayorvecwould also help.