Add top navbar element for Slang landing page in the Guide#173
Add top navbar element for Slang landing page in the Guide#173marty-johnson59 merged 1 commit intomainfrom
Conversation
Do not merge this until KhronosGroup/Vulkan-Guide#369 is completed and merged.
|
Preview site published: https://KhronosGroup.github.io/Vulkan-Site/PR-173/ |
@gpx1000 the preview link posted is dead - is the per-PR publishing scheme working as intended? |
I'm not sure what the question is here. that link looks like it worked when I clicked on it. https://github.khronos.org/Vulkan-Site/PR-173/spec/latest/index.html It took me there so it looks like it might have worked? Unless I missed something and you're asking about if it grabbed the wrong thing from somewhere? |
I see it now, but it was dead immediately after I received the preview notification. I checked several times. Maybe it was a transient GH issue or maybe there is some pipeline delay in actually publishing. |
|
That might be a to be expected. It might take time before whatever the server is that gh uses decides to update the cache or something? I'm not completely familiar with the rules. From the documentation and my tests, I have an expectation that the site will be there within a few minutes of being published. Given this is kind of a hacky way to do the whole PR per action thing, I'm inclined to take that kind of limitation. It hopefully should auto delete when the branch is closed (after merging), so hopefully this will prove to work well for our needs. |
|
@marty-johnson59 I think this was merged accidentally during the docs call, since the underlying Slang landing page in the Guide (KhronosGroup/Vulkan-Guide#373) has not been merged in that repo, yet. Can you confirm? If so I think I'll need to revert it and push a new PR, else we'll have a dead link in the topbar nav. |
|
Yes, mistakenly merged...Revered to new PR (202) |
3 participants
Do not merge this until
KhronosGroup/Vulkan-Guide#373 is completed and merged.