Merged
Conversation
Signed-off-by: Nikolai Ludwig <nliudvig@nvidia.com>
Signed-off-by: Nikolai Ludwig <nliudvig@nvidia.com>
Signed-off-by: Nikolai Ludwig <nliudvig@nvidia.com>
|
@ludwig-n Do we have 100% of the gold patches across languages passing all tests? If not, can we list the instance ids for the failed ones here as a record? |
Collaborator
Author
|
Sure! Instances where gold patches consistently fail:
Instances that are inconsistent (sometimes pass and sometimes fail):
For these instances the reason is most likely port conflict issues, but they aren't easy to fix because the ports in question are hardcoded in the test code. |
gwarmstrong
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes several issues with SWE-bench Multilingual evaluation that arise when running inside of unpriviliged Apptainer containers on a cluster. Specifically, it fixes several instances where gold patches were being evaluated as "unresolved".
mvndto run tests (specifically,google/gsonandapache/druid) now usemvninstead. This is becausemvndfails to run in our setup for some reason. My understanding is thatmvndis basically a more efficient wrapper overmvn, so test results should not be affected.redis/redisandvalkey-io/valkeyinstances are now hardcoded to use different ports for their servers. Previously, they would all use the same port, and it often caused conflicts when running multiple instances on one node (with unprivileged Apptainer containers, there is no way to isolate the ports without cutting off Internet access).micropython/micropythoninstances now run tests sequentially instead of in parallel. Previously, the parallel runs resulted in race conditions when printing the test results, causing the parser to interpret them incorrectly.After these fixes, gold patches for these instances now pass successfully.
None of these are Python repositories, so evaluation for Python-only datasets like SWE-bench Verified is unaffected by this change.