Skip to content

Conversation

@Apurba-01
Copy link

This PR improves promptshell's input handling and terminal interaction for better cross-platform support.

  • Enhanced main loop to support custom input methods and terminal clear commands (promptshell/main.py)
  • Refactored readline setup for robust tab completion, history, and environment detection (promptshell/readline_setup.py)
  • Improved modularity, maintainability, and user experience across platforms

issue #50
closes #50

@Apurba-01
Copy link
Author

Apurba-01 commented Jun 26, 2025

Please review and merge the pull request @Kirti-Rathi

Copy link
Owner

@Kirti-Rathi Kirti-Rathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tab completions works fine but there's an issue, the first input is being ignored entirely, there's no confirmation prompt or execution. The expected behavior (confirmation followed by execution) only begins from the second input onward. This creates a confusing user experience, as it appears the first input does nothing. Attaching screenshot for reference. Kindly fix it and the implementation will be good to go.
image

@Apurba-01
Copy link
Author

Sorry for the Issue withholds.... I will be fixing it as soon possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Tab Completion & Keyboard Shortcuts

2 participants