Skip to content

Conversation

benjamaan476
Copy link
Contributor

@benjamaan476 benjamaan476 commented Sep 25, 2025

Attempt 2

Instead of altering the existing FilletEdge Endpoint Solid3dCutEdges endpoint and CutTypeV2 have been added instead

Copy link

codecov bot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@afd7a73). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #968   +/-   ##
=======================================
  Coverage        ?   30.17%           
=======================================
  Files           ?       36           
  Lines           ?     1750           
  Branches        ?        0           
=======================================
  Hits            ?      528           
  Misses          ?     1222           
  Partials        ?        0           
Flag Coverage Δ
unittests 30.17% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@benjamaan476 benjamaan476 requested review from adamchalmers and jtran and removed request for adamchalmers September 30, 2025 13:40
@benjamaan476 benjamaan476 marked this pull request as ready for review September 30, 2025 13:40
@benjamaan476 benjamaan476 merged commit cbd698d into main Sep 30, 2025
13 of 14 checks passed
@benjamaan476 benjamaan476 deleted the ben/chamfer_angle branch September 30, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants