Skip to content

Conversation

@davreev
Copy link
Contributor

@davreev davreev commented Nov 19, 2025

Update CameraViewState after engine camera rework

Corresponding engine PR: kittycad/engine#3962

@davreev davreev force-pushed the david/camera-view-state-update branch from 2303cb6 to b746fd2 Compare November 19, 2025 19:26
@davreev davreev marked this pull request as draft November 19, 2025 19:38
@davreev davreev force-pushed the david/camera-view-state-update branch from b746fd2 to f5d7532 Compare November 19, 2025 20:11
@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@3c5494b). Learn more about missing BASE report.

Files with missing lines Patch % Lines
modeling-cmds/src/shared.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #997   +/-   ##
=======================================
  Coverage        ?   30.13%           
=======================================
  Files           ?       36           
  Lines           ?     1752           
  Branches        ?        0           
=======================================
  Hits            ?      528           
  Misses          ?     1224           
  Partials        ?        0           
Flag Coverage Δ
unittests 30.13% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants