fix: add better errors for missing commas in arrays and objects #5079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
TomPridham
commented
Jan 16, 2025
| @@ -259,6 +270,14 @@ impl<'a> winnow::stream::StreamIsPartial for TokenSlice<'a> { | |||
| } | |||
| } | |||
|
|
|||
| impl<'a> winnow::stream::FindSlice<&str> for TokenSlice<'a> { | |||
There was a problem hiding this comment.
I had to implement this to use take_until. I wasn't sure if there was a better way to check and see if there was a closing bracket or not. Using take_till always returned Ok even if the token wasn't present
TomPridham
force-pushed
the
kc-5055/missing-comma-message
branch
from
c1c5d29 to
3441557
Compare
TomPridham
force-pushed
the
kc-5055/missing-comma-message
branch
from
3441557 to
79943ee
Compare
TomPridham
force-pushed
the
kc-5055/missing-comma-message
branch
from
79943ee to
9ff3bde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5055
Adds better error messaging for missed commas in objects and arrays and adds the same missing closing bracket message for objects