Fix: Ignore KCL changes when loading settings and fixed useEffect to use .current

src/components/ModelingMachineProvider.tsx

@@ -123,7 +123,6 @@ export const ModelingMachineProvider = ({
       },
     },
   } = useSettingsAuthContext()
-  const previousAllowOrbitInSketchMode = useRef(allowOrbitInSketchMode.current)
   const navigate = useNavigate()
   const { context, send: fileMachineSend } = useFileContext()
   const { file } = useLoaderData() as IndexLoaderData
@@ -1205,14 +1204,6 @@ export const ModelingMachineProvider = ({
   }, [engineCommandManager.engineConnection, modelingSend])
 
   useEffect(() => {
-    // Only trigger this if the state actually changes, if it stays the same do not reload the camera
-    if (
-      previousAllowOrbitInSketchMode.current === allowOrbitInSketchMode.current
-    ) {
-      //no op
-      previousAllowOrbitInSketchMode.current = allowOrbitInSketchMode.current
-      return
-    }
     const inSketchMode = modelingState.matches('Sketch')
 
     // If you are in sketch mode and you disable the orbit, return back to the normal view to the target
@@ -1235,9 +1226,7 @@ export const ModelingMachineProvider = ({
     if (inSketchMode) {
       sceneInfra.camControls.enableRotate = allowOrbitInSketchMode.current
     }
-
-    previousAllowOrbitInSketchMode.current = allowOrbitInSketchMode.current
-  }, [allowOrbitInSketchMode])
+  }, [allowOrbitInSketchMode.current])
 
   // Allow using the delete key to delete solids
   useHotkeys(['backspace', 'delete', 'del'], () => {

src/components/SettingsAuthProvider.tsx

@@ -36,7 +36,11 @@ import {
   loadAndValidateSettings,
 } from 'lib/settings/settingsUtils'
 import { reportRejection } from 'lib/trap'
-import { getAppSettingsFilePath } from 'lib/desktop'
+import {
+  getAppSettingsFilePath,
+  isPathAProjectSettingsFile,
+  isPathASettingsFile,
+} from 'lib/desktop'
 import { isDesktop } from 'lib/isDesktop'
 import { useFileSystemWatcher } from 'hooks/useFileSystemWatcher'
 import { codeManager } from 'lib/singletons'
@@ -226,7 +230,15 @@ export const SettingsAuthProviderBase = ({
   }, [])
 
   useFileSystemWatcher(
-    async (eventType: string) => {
+    async (eventType: string, path: string) => {
+      const exitEarly = !(
+        isPathASettingsFile(path) || isPathAProjectSettingsFile(path)
+      )
+      if (exitEarly) {
+        // The file is not a settings file, exit early!
+        return
+      }
+
       // If there is a projectPath but it no longer exists it means
       // it was exterally removed. If we let the code past this condition
       // execute it will recreate the directory due to code in

src/lib/desktop.ts

@@ -15,6 +15,7 @@ import {
   TELEMETRY_FILE_NAME,
   TELEMETRY_RAW_FILE_NAME,
   TOKEN_FILE_NAME,
+  FILE_EXT,
 } from './constants'
 import { DeepPartial } from './types'
 import { ProjectConfiguration } from 'wasm-lib/kcl/bindings/ProjectConfiguration'
@@ -625,3 +626,15 @@ export const getUser = async (
   }
   return Promise.reject(new Error('unreachable'))
 }
+
+export const isPathAKCLFile = (path: string): boolean => {
+  return path.endsWith(FILE_EXT)
+}
+
+export const isPathASettingsFile = (path: string): boolean => {
+  return path.endsWith(SETTINGS_FILE_NAME)
+}
+
+export const isPathAProjectSettingsFile = (path: string): boolean => {
+  return path.endsWith(PROJECT_SETTINGS_FILE_NAME)
+}