Allow multiple profiles in the same sketch #5196
Merged
+40,606
−19,836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit efe8089.
* Add Rust side artifacts for startSketchOn face or plane * move ast digging --------- Co-authored-by: Kurt Hutten Irev-Dev <[email protected]>
…e not ready with name params yet
…riteToFile` It is already debounced internally. If we await it, we will have to wait for a debounced timeout
franknoirot
changed the title
pierremtb
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
Went through the changes at a high level. Kudos for getting this to a mergeable state. Local testing looks good to me too ❤️
Waiting on @franknoirot's approval before merging
| }, | ||
| ], | ||
| // TODO FIXME, similar to fix me in e2e/playwright/testing-selections.spec.ts | ||
| // also related to deleting, deleting in general probably is due for a refactor |
There was a problem hiding this comment.
Just noticed this deletion of Sketch in the feature tree leads to the sketch var to be delete but not the profiles in it. This can totally be fixed in a subsequent PR, I can take care of opening up a new issue for this.
Screen.Recording.2025-02-14.at.8.43.35.AM.copy.mov
There was a problem hiding this comment.
As discussed on Slack @franknoirot
franknoirot
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ready I think, battling tests a little bit, but that shouldn't hold up reviews
Refer to this PR for the main PR description.
#4532
Things that are different from that PR is that three-point-circle had some work done with it, it also required that each segment now has many groups of overlays to account for the three handles of three-point-circle that all have x-y inputs
There is some kwarg related work in there two.
closes #4828
closes #4619
closes #5191
closes #4233
closes #2931
closes #3082
closes #1876
closes #2426
closes #589