Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Delete to right-click context menu of feature tree operations #5302

Draft
wants to merge 157 commits into
base: main
Choose a base branch
from
Draft

Add Delete to right-click context menu of feature tree operations #5302

wants to merge 157 commits into from
+241 −54

Conversation

pierremtb
Copy link
Collaborator

@pierremtb pierremtb commented Feb 7, 2025 •
edited
Loading

Maps a new context menu item to a new Feature Tree Machine state to handle deletion.

Screen.Recording.2025-02-12.at.5.36.57.PM.mov

Todo before ready:

image

Irev-Dev and others added 30 commits December 18, 2024 07:08
@Irev-Dev
Revert "Revert multi-profile (#4812)"
1e9cf6f 
This reverts commit efe8089.
@Irev-Dev
fix poor 1000ms wait UX
e60cabb
@Irev-Dev
Merge remote-tracking branch 'origin' into kurt-bring-back-multi-profile
30edf2a
@github-actions
A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest-8-cores)
c696f08
@Irev-Dev
trigger CI
2c40e8a
@jtran @Irev-Dev
Add Rust side artifacts for startSketchOn face or plane (#4834)
3865637 
* Add Rust side artifacts for startSketchOn face or plane

* move ast digging

---------

Co-authored-by: Kurt Hutten Irev-Dev <[email protected]>
@Irev-Dev
Merge remote-tracking branch 'origin' into kurt-bring-back-multi-profile
1b9f5f2
@Irev-Dev
lint
9f93346
@Irev-Dev
lint
e9086c5
@github-actions
A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-macos…
913f264 
…-8-cores)
@github-actions
A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubunt…
7197b6c 
…u-8-cores)
@github-actions
A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-16-cores)
9f323c2
@Irev-Dev
trigger CI
68c8974
@nadr0 @Irev-Dev
chore: disabled file watcher which prevents faster file write (#4835)
6add1d7
@github-actions @Irev-Dev
A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubunt…
0642e49 
…u-8-cores)
@Irev-Dev
partial fixes
6c9d14a
@github-actions
A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubunt…
b09c240 
…u-8-cores)
@pierremtb
Trigger CI
2bb548c
@jtran
Merge branch 'main' into kurt-bring-back-multi-profile
d3e4b12
@github-actions
A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubunt…
fcf3272 
…u-8-cores)
@jtran
Trigger CI
3344208
@lf94
Fix up all the tests
30397ba
@lf94
Fix partial execution
5fe3023
@lf94
Merge branch 'main' into lf94/kurt-bring-back-multi-profile
482487c
@lf94
Merge branch 'main' into lf94/kurt-bring-back-multi-profile
648616c
@lf94
wip
32e8975
@lf94
WIP
9008648
@lf94
wip
b3467bb
@Irev-Dev
rust changes to make three point confrom to same as others since we'r…
33468c4 
…e not ready with name params yet
@Irev-Dev
most of the fix for 3 point circle
5a5138a
@pierremtb pierremtb requested a review from max-mrgrsk February 12, 2025 22:15
jtran and others added 18 commits February 12, 2025 18:34
@jtran
Merge branch 'main' into kurt-multi-profile-again
500d92d
@Irev-Dev
Merge remote-tracking branch 'origin' into kurt-multi-profile-again
d7f834f
@Irev-Dev
clean up for face codeRef
9a89926
@Irev-Dev
Merge remote-tracking branch 'origin' into kurt-multi-profile-again
b390e3e
@Irev-Dev
fix changing tools part way through circle/rect tools
9999e4e
@Irev-Dev
fix delete of circle profile
0208eec
@Irev-Dev
fix close profiles
b937934
@Irev-Dev
fix closing profile bug (tangentArcTo being ignored)
b4d1a36
@Irev-Dev
remove stale comment
bf1a42f
@franknoirot
Delete paths associated with sketch when the sketch plane is deleted
3747db0
@franknoirot
Add support for deleting sketches on caps (not walls)
09f3e6e
@Irev-Dev @franknoirot
get delet working for walls
42016b7
@Irev-Dev @franknoirot
make delet of extrusions work for multi profile
df89774
@github-actions
A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubunt…
4ea1338 
…u-8-cores)
@franknoirot
Delete the sketch statement too on the cap and wall cases
acb399a
@franknoirot
Don't write to file in split-sketch-pipe-if-needed unless necessary
4acf74f
@franknoirot
Don't wait for file write to complete within `updateEditorWithAstAndW…
18d5bb3 
…riteToFile`

It is already debounced internally. If we await it, we will have to wait for a debounced timeout
@pierremtb
Merge branch 'kurt-multi-profile-again' into pierremtb/issue5090-Add-…
be65086 
…Delete-right-click-menu-item-to-Feature-Tree
@pierremtb pierremtb changed the base branch from main to kurt-multi-profile-again February 13, 2025 21:08
Base automatically changed from kurt-multi-profile-again to main February 14, 2025 13:57
@pierremtb pierremtb marked this pull request as draft February 14, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franknoirot franknoirot Awaiting requested review from franknoirot

@Irev-Dev Irev-Dev Awaiting requested review from Irev-Dev

@jtran jtran Awaiting requested review from jtran

@lf94 lf94 Awaiting requested review from lf94

@nadr0 nadr0 Awaiting requested review from nadr0

@max-mrgrsk max-mrgrsk Awaiting requested review from max-mrgrsk

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pierremtb @Irev-Dev @jtran @nadr0 @lf94 @franknoirot