Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a settings annotation to all new files #5313

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

franknoirot
Copy link
Collaborator

@franknoirot franknoirot commented Feb 7, 2025

Stacked on top of #5310. Another step towards #3960. Any new files now get a settings annotation based on the current setting value. Combined with #5212, this makes the project-level setting have no effect on newly-created files and projects, since inline annotations take precedence.

Copy link

qa-wolf bot commented Feb 7, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Feb 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app 🔄 Building (Inspect) Visit Preview Feb 14, 2025 4:37pm

@franknoirot franknoirot changed the base branch from main to jtran/fix-units-empty-program February 7, 2025 22:49
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.05%. Comparing base (b3acb34) to head (980c139).

Additional details and impacted files
@@                      Coverage Diff                       @@
##           jtran/fix-units-empty-program    #5313   +/-   ##
==============================================================
  Coverage                          86.05%   86.05%           
==============================================================
  Files                                 92       92           
  Lines                              33284    33284           
==============================================================
  Hits                               28643    28643           
  Misses                              4641     4641           
Flag Coverage Δ
wasm-lib 86.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jtran jtran force-pushed the jtran/fix-units-empty-program branch from b3acb34 to 224c03f Compare February 11, 2025 20:43
Base automatically changed from jtran/fix-units-empty-program to main February 11, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants