-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UoM types in AST, unnamed annotations, and syntax for importing from std #5324
Conversation
Signed-off-by: Nick Cameron <[email protected]>
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This PR also fixes a few bugs/omissions:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5324 +/- ##
==========================================
- Coverage 86.04% 85.89% -0.15%
==========================================
Files 92 92
Lines 33261 33456 +195
==========================================
+ Hits 28620 28738 +118
- Misses 4641 4718 +77
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* CM KCL: add annotations * Make AnnotationName a token that includes the @ * The text of AnnotationName is now optional (#5324) --------- Co-authored-by: Matt Mundell <[email protected]>
This is preparatory work for declaring std using KCL (extracted from #5147).
Numeric suffixes are now preserved in the AST, but we still don't actually have any effect. (But it means formatting the AST won't drop them, etc).