Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KCL: Linear/circular pattern use keyword args (with Kevin's e2e fixes) #5334

Open
wants to merge 57 commits into
base: main
Choose a base branch
from

Conversation

adamchalmers
Copy link
Collaborator

@adamchalmers adamchalmers commented Feb 11, 2025

Combination of #5315 and #5269

nadr0 and others added 30 commits February 4, 2025 14:47
…oes not work since there are errors in the KCL code
…ne state that is flaky, added toast if someone presses the command bar too quickly
…CAD/modeling-app into nadro/adhoc/ubuntu-e2e-local-fixes
Copy link

qa-wolf bot commented Feb 11, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Feb 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Feb 11, 2025 4:21pm

Copy link
Contributor

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 78.42004% with 112 lines in your changes missing coverage. Please review.

Project coverage is 85.82%. Comparing base (74bdb72) to head (8972ddb).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/wasm-lib/kcl/src/parsing/ast/types/mod.rs 53.01% 39 Missing ⚠️
src/wasm-lib/kcl/src/parsing/parser.rs 67.81% 28 Missing ⚠️
src/wasm-lib/kcl/src/execution/exec_ast.rs 73.23% 19 Missing ⚠️
src/wasm-lib/kcl/src/parsing/token/mod.rs 0.00% 13 Missing ⚠️
src/wasm-lib/kcl/src/execution/mod.rs 70.58% 10 Missing ⚠️
src/wasm-lib/kcl/src/execution/artifact.rs 90.00% 2 Missing ⚠️
...sm-lib/kcl/src/execution/artifact/mermaid_tests.rs 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5334      +/-   ##
==========================================
- Coverage   86.04%   85.82%   -0.23%     
==========================================
  Files          92       94       +2     
  Lines       33261    33595     +334     
==========================================
+ Hits        28620    28833     +213     
- Misses       4641     4762     +121     
Flag Coverage Δ
wasm-lib 85.82% <78.42%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Breaking line(endAbsolute) onto multiple lines changed a bunch of tests
Copy link
Contributor

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants