Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dev experience on windows #5335

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

pierremtb
Copy link
Collaborator

@pierremtb pierremtb commented Feb 11, 2025

Adds the following powershell scripts:

yarn install:tools:windows
yarn fetch:wasm:windows
yarn files:flip-to-nightly:windows

Copy link

qa-wolf bot commented Feb 11, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Feb 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ❌ Failed (Inspect) Feb 13, 2025 3:14pm

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.81%. Comparing base (a572d7b) to head (d2fd635).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5335   +/-   ##
=======================================
  Coverage   85.81%   85.81%           
=======================================
  Files          94       94           
  Lines       34533    34533           
=======================================
  Hits        29634    29634           
  Misses       4899     4899           
Flag Coverage Δ
wasm-lib 85.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@franknoirot
Copy link
Collaborator

franknoirot commented Feb 13, 2025

Update: changing jq to jqlang.jq fixed the issue for me

I get the following error for the first script on my new laptop:

yarn install:tools:windows
yarn run v1.22.22
$ winget install Schniz.fnm jq yq
Multiple packages found matching input criteria. Please refine the input.
Name           Id           Source
-----------------------------------
JQuery参考手册 9NBLGGH4P48H msstore
jq             jqlang.jq    winget
Multiple packages found for: jq
error Command failed with exit code 2316632167.

package.json Outdated Show resolved Hide resolved
package.json Outdated
@@ -84,8 +84,10 @@
"simpleserver:stop": "kill-port 3000",
"fmt": "prettier --write ./src *.ts *.json *.js ./e2e ./packages",
"fmt-check": "prettier --check ./src *.ts *.json *.js ./e2e ./packages",
"fetch:wasm": "./get-latest-wasm-bundle.sh",
"fetch:samples": "echo \"Fetching latest KCL samples...\" && curl -o public/kcl-samples-manifest-fallback.json https://raw.githubusercontent.com/KittyCAD/kcl-samples/achalmers/kw-pattern/manifest.json",
"install:tools:windows": "winget install Schniz.fnm jqlang.jq MikeFarah.yq",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey I could even add rustup in there looking at https://www.petergirnus.com/blog/how-to-install-rust-on-windows

winget is getting awesome

Copy link
Collaborator

@franknoirot franknoirot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are super helpful! I didn't test files:flip-to-nightly:windows because I'm not sure what it's used for. On a new machine, I had to first associate .ps1 files with Powershell in my settings; that seems more like a problem with Windows than us, don't know if it's worth documenting.

Oh and I don't know if updating jq to jqlang.jq works for you, but install:tools:windows didn't for me otherwise.

@pierremtb pierremtb marked this pull request as draft February 13, 2025 14:45
@pierremtb
Copy link
Collaborator Author

@franknoirot thanks so much for testing. Back to draft as there's a few more things I'd like to add, including a way to install wasm-pack and potentially rust in the first place too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants