-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve dev experience on windows #5335
base: main
Are you sure you want to change the base?
Conversation
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5335 +/- ##
=======================================
Coverage 85.81% 85.81%
=======================================
Files 94 94
Lines 34533 34533
=======================================
Hits 29634 29634
Misses 4899 4899
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Update: changing I get the following error for the first script on my new laptop:
|
package.json
Outdated
@@ -84,8 +84,10 @@ | |||
"simpleserver:stop": "kill-port 3000", | |||
"fmt": "prettier --write ./src *.ts *.json *.js ./e2e ./packages", | |||
"fmt-check": "prettier --check ./src *.ts *.json *.js ./e2e ./packages", | |||
"fetch:wasm": "./get-latest-wasm-bundle.sh", | |||
"fetch:samples": "echo \"Fetching latest KCL samples...\" && curl -o public/kcl-samples-manifest-fallback.json https://raw.githubusercontent.com/KittyCAD/kcl-samples/achalmers/kw-pattern/manifest.json", | |||
"install:tools:windows": "winget install Schniz.fnm jqlang.jq MikeFarah.yq", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey I could even add rustup in there looking at https://www.petergirnus.com/blog/how-to-install-rust-on-windows
winget is getting awesome
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are super helpful! I didn't test files:flip-to-nightly:windows
because I'm not sure what it's used for. On a new machine, I had to first associate .ps1
files with Powershell in my settings; that seems more like a problem with Windows than us, don't know if it's worth documenting.
Oh and I don't know if updating jq
to jqlang.jq
works for you, but install:tools:windows
didn't for me otherwise.
@franknoirot thanks so much for testing. Back to draft as there's a few more things I'd like to add, including a way to install wasm-pack and potentially rust in the first place too. |
Adds the following powershell scripts: