Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KCL: Update patternTransform and 2d to use kwargs #5348

Merged
merged 4 commits into from
Feb 12, 2025

Conversation

adamchalmers
Copy link
Collaborator

No description provided.

Copy link

qa-wolf bot commented Feb 11, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Feb 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Feb 12, 2025 7:09pm

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.89%. Comparing base (950f5ce) to head (2355c63).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5348      +/-   ##
==========================================
+ Coverage   85.85%   85.89%   +0.03%     
==========================================
  Files          94       94              
  Lines       34436    34523      +87     
==========================================
+ Hits        29566    29653      +87     
  Misses       4870     4870              
Flag Coverage Δ
wasm-lib 85.89% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@pierremtb pierremtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from what I can tell. Let's merge if the CI is green

@pierremtb pierremtb enabled auto-merge (squash) February 12, 2025 21:44
@pierremtb pierremtb merged commit 592c525 into main Feb 12, 2025
35 checks passed
@pierremtb pierremtb deleted the achalmers/pattern-transform branch February 12, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants