Fix to not send engine commands when only importing functions or constants #5371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jtran
force-pushed
the
jtran/fix-mixed-units
branch
from
0cb99dc to
488c2b2
Compare
jtran
force-pushed
the
jtran/fix-mixed-units
branch
from
488c2b2 to
589595d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5371 +/- ##
==========================================
- Coverage 85.87% 85.85% -0.02%
==========================================
Files 94 94
Lines 34524 34553 +29
==========================================
+ Hits 29649 29667 +18
- Misses 4875 4886 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nrc
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5180. This also fixes a bug where, if you relied on the undesirable behavior to render a part when importing functions, the imported part would have the wrong units.
When examining the output of this PR, keep in mind that in either mock or isolated mode, we still record outgoing commands. The real difference and fix is the rendered scene image in
src/wasm-lib/kcl/tests/import_function_not_sketch/rendered_model.pnggoing from showing a part to being empty because the commands are not actually being sent.We're no longer building the artifact graph because there are no engine responses. But it's inconsequential to this fix. We'll actually bring much of it back in #5093 because a lot of the artifact graph can be built without engine responses.