Disable one multi-profile test and disable all multi-profile tests on Windows #5387
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
This reverts commit 3d53072.
pierremtb
changed the title
pierremtb
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5387 +/- ##
==========================================
- Coverage 85.83% 85.82% -0.01%
==========================================
Files 94 94
Lines 34758 34758
==========================================
- Hits 29833 29831 -2
- Misses 4925 4927 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -1352,7 +1352,7 @@ test.describe(`Sketching with offset planes`, () => { | |||
| }) | |||
| }) | |||
|
|
|||
| test.describe('multi-profile sketching', () => { | |||
| test.describe('multi-profile sketching', { tag: '@skipWin' }, () => { | |||
There was a problem hiding this comment.
I've seen flakes for a few of these on Windows. We have coverage on Ubuntu and macOS, Windows isn't adding anything here.
| @@ -1883,7 +1883,7 @@ profile004 = circleThreePoint(sketch001, p1 = [13.44, -6.8], p2 = [13.39, -2.07] | |||
| }) | |||
| } | |||
| ) | |||
| test( | |||
| test.fixme( | |||
There was a problem hiding this comment.
This one is definitely unhappy on main and a few branches I tried, see https://github.com/KittyCAD/modeling-app/actions/runs/13330664352/job/37248442003
|
Closing, I think we should merge #5391 instead |
Pull request was closed
Cause tests on main aren't passing after 3 retries https://github.com/KittyCAD/modeling-app/actions/runs/13330664352/job/37248442003