More numeric types baby steps #5388
Conversation
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5388 +/- ##
==========================================
- Coverage 85.84% 85.84% -0.01%
==========================================
Files 94 94
Lines 34707 34803 +96
==========================================
+ Hits 29794 29876 +82
- Misses 4913 4927 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| schemars::schema::SingleOrVec::Vec(items) => { | ||
| if items.len() == 2 { | ||
| // Get the second item and see if its a NumericType. |
There was a problem hiding this comment.
Should we create a wrapper type? Jess suggested it might simplify building the docs.
There was a problem hiding this comment.
I might as a follow-up. It's kind of annoying because it's only used where we're extracting the number out of a value, it shouldn't be user-facing at all. There's a lot of places which would need to be changed too
Signed-off-by: Nick Cameron <[email protected]>
Signed-off-by: Nick Cameron <[email protected]>
Signed-off-by: Nick Cameron <[email protected]>
This adds propagation for numeric types through simple arithmetic, but only in the easiest cases. It also propagates a little more through geometry and lays the foundations for propagating through Paths.