Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KCL: Chamfer and fillet now use keyword arguments #5389

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

KCL: Chamfer and fillet now use keyword arguments #5389

wants to merge 5 commits into from

Conversation

adamchalmers
Copy link
Collaborator

@adamchalmers adamchalmers commented Feb 14, 2025 •
edited
Loading

Previously:
|> fillet({ radius = 5, tags = [seg01] }, %)
Now:
|> fillet(radius = 5, tags = [seg01])

@qa-wolf QA Wolf
Copy link

qa-wolf bot commented Feb 14, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@vercel Vercel
Copy link

vercel bot commented Feb 14, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Feb 15, 2025 1:43am

@github-actions GitHub Actions
Copy link
Contributor

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

@github-actions GitHub Actions
Copy link
Contributor

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

@adamchalmers adamchalmers force-pushed the achalmers/kw-args-chamfer branch from a860394 to e23a166 Compare February 14, 2025 20:56
@github-actions GitHub Actions
Copy link
Contributor

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

@adamchalmers adamchalmers force-pushed the achalmers/kw-args-chamfer branch from e23a166 to 53805fe Compare February 14, 2025 20:56
@github-actions GitHub Actions
Copy link
Contributor

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

@github-actions GitHub Actions
Copy link
Contributor

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

@github-actions GitHub Actions
Copy link
Contributor

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

@adamchalmers adamchalmers force-pushed the achalmers/kw-args-chamfer branch from 64b5324 to adf6ef4 Compare February 14, 2025 22:42
@github-actions GitHub Actions
Copy link
Contributor

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

@github-actions GitHub Actions
Copy link
Contributor

src/lib/exampleKcl.ts has been updated in this PR, please review and update the src/routes/onboarding, if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adamchalmers