Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test equipping tools mid tool use removes have baked expression #5403

Merged
merged 6 commits into from
Feb 18, 2025

Conversation

Irev-Dev
Copy link
Collaborator

Follow up from a bug found in
#5196
But a test wasn't written.

Copy link

qa-wolf bot commented Feb 17, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Feb 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Feb 18, 2025 7:38pm

Copy link
Collaborator

@franknoirot franknoirot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the Line tool updating logic too. Test looks good to me

@Irev-Dev Irev-Dev merged commit f5c9f84 into main Feb 18, 2025
32 of 33 checks passed
@Irev-Dev Irev-Dev deleted the kurt-multiprofile-test-follow-1 branch February 18, 2025 20:45
@Irev-Dev
Copy link
Collaborator Author

Thanks for updating the Line tool updating logic too. Test looks good to me

Yeah funny how you find bugs when writing the tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants