Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Fix user settings opening #5414

Merged
merged 9 commits into from
Feb 19, 2025

Conversation

franknoirot
Copy link
Collaborator

Discovered more issues with #5279 fix after switching to a fresh new Windows machine. @pierremtb could you double-check my work here?

  • Create .gitattributes
  • Fix projectPath URI decoding

Copy link

qa-wolf bot commented Feb 18, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Feb 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Feb 19, 2025 5:22pm

@pierremtb
Copy link
Collaborator

Just need to run the linter!

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.84%. Comparing base (3dfc2c8) to head (218c76b).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5414   +/-   ##
=======================================
  Coverage   85.84%   85.84%           
=======================================
  Files          94       94           
  Lines       34707    34707           
=======================================
  Hits        29794    29794           
  Misses       4913     4913           
Flag Coverage Δ
wasm-lib 85.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@franknoirot franknoirot merged commit b98f560 into main Feb 19, 2025
35 checks passed
@franknoirot franknoirot deleted the franknoirot/adhoc/fix-user-settings-windows branch February 19, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants