Skip to content

Customizable Time Filters - #1550

Merged
BryonLewis merged 7 commits into
mainfrom
issue-1539-time-filters
Dec 1, 2025
Merged

BryonLewis merged 7 commits into
mainfrom
issue-1539-time-filters

Conversation

@BryonLewis

@BryonLewis BryonLewis commented Nov 25, 2025 •

Copy link
Copy Markdown
Collaborator

resolves #1539

  • Quick linting for MultiCamTools.vue
  • adds timeFilter to BaseFilterControls.ts
  • implements time range filtering in TrackFilterControls.ts
  • Updates Controls.vue to include new icon and sliders for adjust the timeFilter range
  • Fixes an issue in LineChart.vue that caused multiple tooltips to display
  • Timeline.vue:
    • Refactors into <script lang='ts'> with defineComponent structure
    • Adds vertical start/end bars (green/red) for the timeline when filtering is active
    • Dims areas outside of the start/end bars
    • Enables dragging and dropping of the start/end bars.

Awaiting feedback but here is the current implementation:

DIVE-20251125-TimeFilter.mp4

@BryonLewis BryonLewis changed the title Issue 1539 time filters Customizable Time Filters Nov 25, 2025
@BryonLewis
BryonLewis requested a review from naglepuff December 1, 2025 16:17
naglepuff
naglepuff previously approved these changes Dec 1, 2025

@naglepuff naglepuff left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had some minor comments about the refactor but the functionality works and most changes are straightforward and not controversial. As long as there are no major changes requested from users I don't mind this being merged.

Comment thread client/src/components/controls/Controls.vue Outdated
Comment thread client/src/components/controls/Timeline.vue Outdated
Comment thread client/src/components/controls/Timeline.vue Outdated
@BryonLewis
BryonLewis marked this pull request as ready for review December 1, 2025 20:24
@BryonLewis
BryonLewis merged commit f28ba7b into main Dec 1, 2025
4 checks passed
@BryonLewis
BryonLewis deleted the issue-1539-time-filters branch December 1, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adjust Track Start and End Times/Frames

2 participants