Confirm a point-segmented mask without repeating its stereo copy - #1959
Merged
Merged
Conversation
The confirm event re-sent the last prediction with its click points, so the other-camera segmentation, and any error dialog, ran twice.
Selecting a different detection clears the segmentation recipe through resetPoints, which marked the recipe as reset by the user. On Windows the contextmenu of the right-click that selected the detection arrives after it has entered Point edit mode, and handleConfirmRecipe took that mark as a request to finalize, deselecting the detection at once. Clear the recipe on a selection change without counting it as a user reset. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
mattdawkins
added a commit
that referenced
this pull request
Sep 23, 2026
# Conflicts: # client/dive-common/use/useModeManager.spec.ts
…tion Clearing the recipe on a selection change without marking it as a user reset left a right-click that placed no points doing nothing. Remember which mouse press entered edit mode instead: the contextmenu of that press (delivered after mouseup on Windows) is ignored, and any later right-click with nothing placed finalizes the detection as before. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
mattdawkins
added a commit
that referenced
this pull request
Sep 23, 2026
BryonLewis
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code