Skip to content

Move a point segmentation edit to another camera without flashing - #1970

Merged
BryonLewis merged 6 commits into
mainfrom
dev/point-seg-right-click-camera
Sep 24, 2026
Merged

BryonLewis merged 6 commits into
mainfrom
dev/point-seg-right-click-camera

Conversation

@mattdawkins

Copy link
Copy Markdown
Member
  • Right-clicking the detection on another camera in point segmentation deselected it (confirm) before the move reselected it, so it flashed
  • The point editor now locks its pending mask without deselecting when the right-click lands outside its camera, and only confirms/deselects if no other camera took the edit (after mouseup on Linux)

🤖 Generated with Claude Code

…lash

A right-click on the other camera confirmed and deselected first, then reselected.
mattdawkins added a commit that referenced this pull request Sep 24, 2026
…main

# Conflicts:
#	client/src/layers/EditAnnotationLayer.spec.ts
mattdawkins and others added 2 commits September 23, 2026 20:58
tox 4.64 writes it by default, and uv run then refuses server/.venv.
The other cameras keep a live creation editor, so a right-click on one of them confirmed and deselected before the move re-selected.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
mattdawkins added a commit that referenced this pull request Sep 24, 2026
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
On Linux the contextmenu precedes the release GeoJS reports the click on,
so confirming at once made that click re-enter editing. Confirming now
leaves edit mode with the detection selected, as the other types do.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
mattdawkins added a commit that referenced this pull request Sep 24, 2026
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

# Conflicts:
#	client/dive-common/use/useModeManager.spec.ts
mattdawkins added a commit that referenced this pull request Sep 24, 2026
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

# Conflicts:
#	client/dive-common/use/useModeManager.spec.ts
@BryonLewis
BryonLewis self-requested a review September 24, 2026 13:44
@BryonLewis
BryonLewis merged commit 550202c into main Sep 24, 2026
3 checks passed
@BryonLewis
BryonLewis deleted the dev/point-seg-right-click-camera branch September 24, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants