Skip to content

Fix add-on installed checkmarks on the web admin page - #1997

Merged
BryonLewis merged 1 commit into
mainfrom
dev/addons-installed-status
Sep 28, 2026
Merged

BryonLewis merged 1 commit into
mainfrom
dev/addons-installed-status

Conversation

@mattdawkins

Copy link
Copy Markdown
Member
  • GET dive_configuration/addons returns [name, url, description, installed]; the client read index 3, which became the CSV's MD5 column, so every add-on showed installed
  • Installed lookup uses the worker's _addon_zip_path_for_url, so Google Drive add-ons (gdrive_<id>.zip) match

🤖 Generated with Claude Code

The admin page reads column 3 as the installed flag, but the add-on CSV
grew columns so it read the MD5 and showed every add-on as installed.
Google Drive add-ons also never matched their gdrive_<id>.zip name.
@mattdawkins
mattdawkins force-pushed the dev/addons-installed-status branch from c8f0abd to 8225706 Compare September 28, 2026 16:24

@BryonLewis BryonLewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was curious as to why this was needed. The CSV changed earlier this year and the order/number of columns changed and I wasn't aware. This syncs them back up/

@BryonLewis
BryonLewis merged commit 56f23fc into main Sep 28, 2026
3 checks passed
@BryonLewis
BryonLewis deleted the dev/addons-installed-status branch September 28, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants