Skip to content

Remove TODO in code related to date removal #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pchoisel merged 1 commit into from
Aug 27, 2025
Merged

Remove TODO in code related to date removal #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions tests/test_anon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,7 @@ def test_deleted_tags_are_removed(orig_anon_dataset):
if (
len(tt) == 2 and tt in orig_ds
): # sourcery skip: merge-nested-ifs, no-conditionals-in-tests
# TODO: Investigate why Date type are replaced instead of deleted
# See issue https://github.com/KitwareMedical/dicom-anonymizer/issues/56
# Date type are replaced instead of deleted. See README.md.
if orig_ds[tt].VR != "DA": # sourcery skip: no-conditionals-in-tests
assert tt not in anon_ds, (
f"({tt[0]:04X},{tt[1]:04x}):{orig_ds[tt].value}->{anon_ds[tt].value}"
Expand Down