Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permissions reset #196

Open
JayDwee opened this issue May 29, 2021 · 2 comments · May be fixed by #239
Open

Permissions reset #196

JayDwee opened this issue May 29, 2021 · 2 comments · May be fixed by #239
Labels
bug Something isn't working

Comments

@JayDwee
Copy link
Member

JayDwee commented May 29, 2021

Describe the bug

Creating a RFR in the channel removed the 'everyone can't message' perm, reset it to default instead

To Reproduce

Numbered steps to reproduce the behavior:

  1. Set perms for everyone to 'send messages' = False
  2. Create a RFR in that channel
  3. @ everyone 'send messages' will be set back to defaults

Expected behaviour

'send messages' should not be altered, only add reactions

Screenshots

N/A

Additional context

N/A
@JayDwee JayDwee added bug Something isn't working medium priority labels May 29, 2021
@jplam123
Copy link

jplam123 commented Aug 4, 2021

All text channel permissions reset when altering them. Not just sending messages.

@jplam123
Copy link

jplam123 commented Aug 4, 2021 •
edited
Loading

All text channel permissions reset when altering them. Not just sending messages.

Fixed issue, problem lied in implementation of overwrite permissions, cannot reuse. The same one, will create PR soon.

jplam123 added a commit that referenced this issue Aug 4, 2021
@jplam123
Fixed: Bug, #196 permissions reset when creating rfr
d7e58d9 
Signed-off-by: Jonathan <[email protected]>
@jplam123 jplam123 linked a pull request Aug 4, 2021 that will close this issue
Draft
10 tasks
@Kaspiaan Kaspiaan self-assigned this Oct 18, 2021
Kaspiaan added a commit that referenced this issue Oct 20, 2021
@Kaspiaan
Revert "Fixed: Bug, #196 permissions reset when creating rfr"
2342fc4 
This reverts commit d7e58d9.
@JayDwee JayDwee changed the title [RFR] Permissions reset Permissions reset Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed: Bug #196 permissions reset when creating rfr KoalaBotUK/KoalaBot
3 participants
@JayDwee @Kaspiaan @jplam123