Fixed: Bug #196 permissions reset when creating rfr #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan <[email protected]>
Signed-off-by: Jonathan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #239 +/- ##
=======================================
Coverage 83.48% 83.48%
=======================================
Files 27 27
Lines 6671 6672 +1
=======================================
+ Hits 5569 5570 +1
Misses 1102 1102
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Kaspiaan
reviewed
Aug 8, 2021
Kaspiaan
requested changes
Aug 8, 2021
JayDwee
requested changes
Aug 9, 2021
Comment on lines
939
to
+940
| role: discord.Role = discord.utils.get(guild.roles, id=guild.id) | ||
| overwrite: discord.PermissionOverwrite = discord.PermissionOverwrite() | ||
| overwrite.update(add_reactions=False) | ||
| await channel.set_permissions(role, overwrite=overwrite) | ||
| perms = channel.overwrites_for(role) |
There was a problem hiding this comment.
All current roles should have the add_reactions perm set to false, not just everyone. (although this successfully doesn't screw with other perms, as mentioned in issue, gj!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jonathan [email protected]
Summary
fixes bug where it would default permissions if a rfr is created close #196
Checklist
CHANGELOG.mdunder the[Unreleased]heading?documentation.json?