-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ColourRole] fix unexpected error due to cooldown #228
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #228 +/- ##
==========================================
- Coverage 83.48% 83.46% -0.02%
==========================================
Files 27 27
Lines 6671 6672 +1
==========================================
Hits 5569 5569
- Misses 1102 1103 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add changes made to the changelog, you can pretty much put the issue name under a Colour Role heading
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may seem trivial, but please add this onto the changelog so we have an idea of what's been changed as we go along.
Edit: Apologies for the double comment, forgot I'd already done a comment of this exact thing.
CodeCoverage Fails after 1s - Need to take a look at. |
Summary
closes #216 by fixing the unexpected error due to cooldown
Checklist
CHANGELOG.md
under the[Unreleased]
heading?documentation.json
?