Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ColourRole] fix unexpected error due to cooldown #228

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

slushiegoose
Copy link

@slushiegoose slushiegoose commented Jul 26, 2021

Summary

closes #216 by fixing the unexpected error due to cooldown

Checklist

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

  • Have you tested the changes? (pytest & dpytest)
  • Have you followed PEP-8 for naming and styling?
  • Has your code been properly documented with RestructuredText docstrings?
  • Have you added your changes to CHANGELOG.md under the [Unreleased] heading?
  • If your code added new bot commands, have you updated documentation.json?

  • All of this code is your own, or follows the author repo's licence.

@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #228 (f7d3a31) into master (b4f0b87) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #228      +/-   ##
==========================================
- Coverage   83.48%   83.46%   -0.02%     
==========================================
  Files          27       27              
  Lines        6671     6672       +1     
==========================================
  Hits         5569     5569              
- Misses       1102     1103       +1     
Flag Coverage Δ
unittests 83.46% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cogs/ColourRole.py 88.55% <0.00%> (-0.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4f0b87...f7d3a31. Read the comment docs.

Copy link
Member

@Kaspiaan Kaspiaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add changes made to the changelog, you can pretty much put the issue name under a Colour Role heading

Copy link
Member

@Kaspiaan Kaspiaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may seem trivial, but please add this onto the changelog so we have an idea of what's been changed as we go along.

Edit: Apologies for the double comment, forgot I'd already done a comment of this exact thing.

@slushiegoose slushiegoose requested a review from Kaspiaan August 8, 2021 05:12
@Kaspiaan Kaspiaan marked this pull request as draft November 9, 2021 00:48
@VirajShah18
Copy link
Contributor

CodeCoverage Fails after 1s - Need to take a look at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cooldown causes unexpected error
3 participants