Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AdvancedVerify] #230

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

[AdvancedVerify] #230

wants to merge 3 commits into from

Conversation

slushiegoose
Copy link

Summary

Adds a new koala extension AdvancedVerify (close #93)

Checklist

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

  • Have you tested the changes? (pytest & dpytest)
  • Have you followed PEP-8 for naming and styling?
  • Has your code been properly documented with RestructuredText docstrings?
  • Have you added your changes to CHANGELOG.md under the [Unreleased] heading?
  • If your code added new bot commands, have you updated documentation.json?

  • All of this code is your own, or follows the author repo's licence.

@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #230 (d2091c9) into master (85c3be5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #230   +/-   ##
=======================================
  Coverage   82.27%   82.27%           
=======================================
  Files          26       26           
  Lines        6453     6453           
=======================================
  Hits         5309     5309           
  Misses       1144     1144           
Flag Coverage Δ
unittests 82.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cogs/Verification.py 65.85% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85c3be5...d2091c9. Read the comment docs.

@slushiegoose slushiegoose changed the title [AdvancedVerify] Advanced Verification beginnings [AdvancedVerify] Jul 26, 2021
@lgtm-com
Copy link

lgtm-com bot commented Jul 26, 2021

This pull request introduces 5 alerts when merging 19d3f34 into 85c3be5 - view on LGTM.com

new alerts:

  • 3 for Unused import
  • 1 for Except block handles 'BaseException'
  • 1 for Module is imported with 'import' and 'import from'

@lgtm-com
Copy link

lgtm-com bot commented Jul 27, 2021

This pull request introduces 2 alerts when merging d2091c9 into 85c3be5 - view on LGTM.com

new alerts:

  • 1 for Except block handles 'BaseException'
  • 1 for Unused import

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AdvancedVerify
1 participant