-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Inline now saved #238
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #238 +/- ##
==========================================
+ Coverage 82.27% 82.40% +0.13%
==========================================
Files 26 27 +1
Lines 6453 6560 +107
==========================================
+ Hits 5309 5406 +97
- Misses 1144 1154 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
cogs/ReactForRole.py
Outdated
@@ -1078,9 +1110,19 @@ def create_tables(self): | |||
UNIQUE (guild_id, role_id) | |||
); | |||
""" | |||
sql_create_inline_all_status_table = """ | |||
CREATE TABLE IF NOT EXISTS InlineAllStatus ( | |||
guild_id integer NOT NULL, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
guild_id should be text, this is fine for now as I can change it later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Best to change now, removes the need for changing later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed guild_id to be text
Code coverage of tests needs increasing pls |
Summary
close #195
Checklist
CHANGELOG.md
under the[Unreleased]
heading?documentation.json
?