Skip to content

Fix CI failures caused by newer PHPStan and ECS releases - #29

Merged
Kocal merged 1 commit into
mainfrom
fix/ci
Nov 8, 2026
Merged

Kocal merged 1 commit into
mainfrom
fix/ci

Conversation

@Kocal

@Kocal Kocal commented Nov 8, 2026

Copy link
Copy Markdown
Owner

CI installs the latest PHPStan (2.3.5) and easy-coding-standard (13.3), which broke the "Code Style" and "PHPStan Analysis" jobs on every PR. ECS now wants no spaces around | in union types in AttributeFinder.

In LivePropHydrationMethodsRule, each "missing hydrateWith/dehydrateWith" check is reduced to a single null check, because the both-null case is already skipped above. That makes the assert() useless, so it goes away. Behavior is unchanged, and it passes on PHPStan 2.1 and 2.3.

The "Tests" job always installed PHP 8.2 whatever the matrix said. It now uses matrix.php.

CI installs the latest PHPStan (2.3.5) and easy-coding-standard (13.3), which broke the "Code Style" and "PHPStan Analysis" jobs on every PR. ECS now wants no spaces around `|` in union types in `AttributeFinder`.

In `LivePropHydrationMethodsRule`, each "missing hydrateWith/dehydrateWith" check is reduced to a single null check, because the both-null case is already skipped above. That makes the `assert()` useless, so it goes away. Behavior is unchanged, and it passes on PHPStan 2.1 and 2.3.

The "Tests" job always installed PHP 8.2 whatever the matrix said. It now uses `matrix.php`.
@Kocal
Kocal merged commit bb6d36a into main Nov 8, 2026
8 checks passed
@Kocal
Kocal deleted the fix/ci branch November 8, 2026 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant