Skip to content

Extract attribute argument lookup into AttributeFinder - #31

Merged
Kocal merged 1 commit into
mainfrom
refactor/attribute-argument-finder
Nov 8, 2026
Merged

Kocal merged 1 commit into
mainfrom
refactor/attribute-argument-finder

Conversation

@Kocal

@Kocal Kocal commented Nov 8, 2026

Copy link
Copy Markdown
Owner

Seven rules each had their own private loop to read an attribute argument by name, and three of them also by position. They now use AttributeFinder::findArgument() and AttributeFinder::findStringArgumentValue().

Behavior is unchanged, and rules that only matched named arguments still do. A new test covers FromMethodMethodMustExistRule with template passed positionally, a path that had no test.

Seven rules each had their own private loop to read an attribute argument by name, and three of them also by position. They now use `AttributeFinder::findArgument()` and `AttributeFinder::findStringArgumentValue()`.

Behavior is unchanged, and rules that only matched named arguments still do. A new test covers `FromMethodMethodMustExistRule` with `template` passed positionally, a path that had no test.
@Kocal Kocal self-assigned this Nov 8, 2026
@Kocal
Kocal merged commit bf2a859 into main Nov 8, 2026
8 checks passed
@Kocal
Kocal deleted the refactor/attribute-argument-finder branch November 8, 2026 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant