Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add issue and PR templates #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add issue and PR templates #2

wants to merge 1 commit into from

Conversation

SherRao
Copy link
Contributor

@SherRao SherRao commented Mar 25, 2025

Description

We need the issue and PR templates in this repo.

Reviewer Checklist

When reviewing this PR, make sure to keep the following in mind:

  • This PR should not span too many unrelated tickets or changes.
    • If it does, consider breaking it up into smaller PRs.
  • Is the code coverage acceptable?
  • Does the preview deployment work as expected?
  • Does this PR pass all tests?
  • Does this PR have a clear list of issues that it closes?
  • Does the code follow the style guidelines of the project?

Author Checklist

Before opening this PR, make sure the PR:

  • Has an assignee or group of assignees.
  • Has a reviewer or a group of reviewers.
  • Is labelled properly.
  • Has an assigned milestone.

Additionally, make sure that:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@SherRao SherRao added the pipeline Related to the CI/CD pipelines for the project label Mar 25, 2025
@SherRao SherRao self-assigned this Mar 25, 2025
aidantrabs
aidantrabs approved these changes Mar 25, 2025
View reviewed changes
Copy link
Member

@aidantrabs aidantrabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

juancwu
juancwu reviewed Mar 25, 2025
View reviewed changes
components/hero.tsx
<div className="container relative z-10 px-4 mx-auto pb-16 sm:pb-20 lg:ml-32">
<div className="flex flex-col-reverse lg:flex-row items-center justify-between gap-8 lg:gap-8">
<div className="w-full lg:w-3/5 space-y-6 lg:space-y-8 text-center lg:text-left">
<Badge className="inline-flex bg-branding-orange/20 text-branding-orange border border-branding-orange/30 hover:bg-branding-orange/30 px-3 py-1 sm:px-4 sm:py-1.5 text-xs sm:text-sm font-medium tracking-wide uppercase">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hover effect was taken away in this badge, is this intended?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juancwu juancwu juancwu left review comments

@aidantrabs aidantrabs aidantrabs approved these changes

@AmirAgassi AmirAgassi Awaiting requested review from AmirAgassi

@GabeDiniz GabeDiniz Awaiting requested review from GabeDiniz

Assignees

@SherRao SherRao

Labels
pipeline Related to the CI/CD pipelines for the project
Projects
SPUR Landing Site
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SherRao @aidantrabs @juancwu