-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sdk): change insomnia.test mechanism to improve the nested test cases #8388
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could there be any compatibility issues since the function passed to test() is executed asynchronously now?
c94a94c
to
9f8593f
Compare
@yaoweiprc This is a good question, theoretically, for those who pass function without |
Nit: Why don't we expose |
@cwangsmv Good catch, it just tries to wrap |
9f8593f
to
2172810
Compare
Updated PR with following changes:
|
2172810
to
69fa119
Compare
Changes
insomnia.test
to improve the nested test casesawait insomnia.test
insomnia.test
andinsomnia.expect
Add sync or async cases in script to test it:
INS-5005