fix: unable to use unix socket with grpc - [INS-5036] #8410
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CurryYangxx
force-pushed
the
fix/grpc-unix
branch
from
0ca63a9 to
a26d287
Compare
|
@ryan-willis I noticed that this seems related to this pr(#8284). Please help to take a look if this is an appropriate approach to handling this unix situation. |
|
unix-grpc.zip |
CurryYangxx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Reason:
The unix URL is different from the normal grpc URL. For example:
unix:///path/to/my/socket.sock, the protocol isunix, and the host should be the whole URL. There is no pathname in this URL.So the
new URL()method is not suitable for handling unix grpc request.