Skip to content

ci(actions): label the v7 action pins with their versions - #306

Merged
swkeever merged 1 commit into
mainfrom
vol-1094-action-pin-comments
Oct 7, 2026
Merged

swkeever merged 1 commit into
mainfrom
vol-1094-action-pin-comments

Conversation

@swkeever

@swkeever swkeever commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

Tracking

Tracks: https://konghq.atlassian.net/browse/VOL-1094 (epic VOL-1077)

Summary

#294, #295 and #298 moved three actions to v7 SHAs, but Dependabot left the old # v6 comments, so the pins read as v6 to anyone auditing them. This PR names the exact release each SHA resolves to (git ls-remote on each action's tags):

Action SHA Tag
actions/checkout 3d3c42e5aac5ba805825da76410c181273ba90b1 v7.0.1
actions/setup-node 820762786026740c76f36085b0efc47a31fe5020 v7.0.0
actions/setup-go b7ad1dad31e06c5925ef5d2fc7ad053ef454303e v7.0.0

It changes comments only, in ci.yml, publish.yml and release-please.yml; no SHA changes. Exact versions match the repo's other pins (# v7.0.1, # v6.1.0), and Dependabot keeps exact-version comments up to date.

The SDK Node 20 lint, tests, and build job keeps its two # v6 comments, because #305 deletes that job. Leaving it alone keeps the two PRs from conflicting.

Verification

  • bash .github/scripts/actionlint.sh: clean.
  • prettier --check .github/workflows/*.yml: clean.
  • git grep -n "# v6$" -- .github: only the two lines in the Node 20 job.

🤖 Generated with Claude Code

Dependabot moved actions/checkout, actions/setup-node and actions/setup-go
to v7 SHAs but left their '# v6' comments. Name the exact release each SHA
resolves to. The Node 20 job keeps its comments; #305 removes that job.
@swkeever
swkeever requested a review from a team as a code owner October 7, 2026 18:50
Copilot AI balanced review requested due to automatic review settings October 7, 2026 18:50
@swkeever

swkeever commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-07T18:52:01.653580Z cf55606 Manual request
🔒 Security Review ✅ Completed 2026-10-07T18:52:32.711137Z cf55606 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: cf55606a37

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: cf55606a37

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@swkeever
swkeever merged commit 96510b9 into main Oct 7, 2026
@swkeever
swkeever deleted the vol-1094-action-pin-comments branch October 7, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants