Skip to content

feat(sdk): validate generated JavaScript transport - #38

Merged
swkeever merged 5 commits into
mainfrom
skeever/vol-930-sdk-architecture-design
Aug 27, 2026
Merged

swkeever merged 5 commits into
mainfrom
skeever/vol-930-sdk-architecture-design

Conversation

@swkeever

@swkeever swkeever commented Aug 27, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Route the five proof-of-concept behaviors through generated Orval transport bindings.
  • Preserve the existing result envelopes and VolcanoAuth compatibility while adding VolcanoClient.
  • Bind the shared SDK contract with jest-cucumber and add deterministic generation checks.

Verification

  • 364 native tests passed.
  • 5/5 live contract scenarios passed.
  • Generation, lint, types, build, dry pack, and package checks passed.

Coordination

This pull request is a draft. No package was published.

@CLAassistant

CLAassistant commented Aug 27, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@swkeever
swkeever marked this pull request as ready for review August 27, 2026 19:00
@swkeever
swkeever requested a review from a team as a code owner August 27, 2026 19:00
Copilot AI lite review requested due to automatic review settings August 27, 2026 19:00

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 01a28eab04

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/generated/volcano-fetch.ts
@swkeever

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 3867748eac

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@swkeever
swkeever merged commit ca9e250 into main Aug 27, 2026
8 checks passed
@swkeever
swkeever deleted the skeever/vol-930-sdk-architecture-design branch August 27, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants