Repository navigation
fix(openapi): parse YAML responses as binary so the spec sync generates - #374
Closed
subnetmarco wants to merge 2 commits into
Closed
subnetmarco wants to merge 2 commits into
subnetmarco wants to merge 2 commits into
Conversation
The Hosting spec now documents GET /openapi.yaml with an application/yaml response. openapi-python-client cannot parse that content type, and the generator runs with --fail-on-warning, so every automatic spec sync failed. Map application/yaml to application/octet-stream as the binary image types already are; the wire Content-Type is unchanged. Co-authored-by: Cursor <cursoragent@cursor.com>
subnetmarco
enabled auto-merge (squash)
October 6, 2026 19:24
subnetmarco
disabled auto-merge
October 6, 2026 20:41
Member
Author
|
Superseded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The automatic OpenAPI sync from Kong/volcano-hosting (
sync-openapi-consumers.yml, job "Sync volcano-sdk-python") has failed on every run, while the CLI, JS, Ruby and web syncs pass. Because of that, the standingchore/sync-openapiPR here stopped updating after 2026-09-19.Cause. The Hosting spec now documents
GET /openapi.yaml(andHEAD), whose200response isapplication/yaml.openapi-python-clientcan't parse that content type, so it warns:scripts/generate_openapi.pyruns the generator with--fail-on-warning, so the warning fails the job.Fix. Add
application/yaml: application/octet-streamtocontent_type_overridesinopenapi-python-client.yaml, the same way the binary image types are already handled. The generated operation returns the raw bytes, and the wireContent-Typeis unchanged.Validation
main'sapi/openapi.bundled.yamlintoopenapi/openapi.yamland ranscripts/generate_openapi.py. It fails onmainwith the warning above and exits 0 with this change.python -m scripts.check_openapithen reports "OpenAPI generated client is up to date".check_openapipasses), so this PR only unblocks the next sync.scripts/check_quality_policy.shpasses.