Repository navigation
feat(sandboxes): expose custom deployments and build logs - #388
Conversation
Keep the existing Project.plan response compatibility values FREE and PRO in the consumer snapshot while syncing the new producer operations. Preserve existing rollout tests.
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bc6e625eb2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ced03adaba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 13468dca50
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
marckong
left a comment
marckong
left a comment
There was a problem hiding this comment.
PR review
Verdict: approve
Completed four review passes: correctness/contracts; authorization, binary handling and resource limits; lifecycle/concurrency and compatibility; adversarial recheck. Reviewed complete base-to-head diffs and surrounding callers/tests, with cross-repository contract comparison against the coordinated Hosting, CLI, SDK and Web changes.
Reviewed management credentials, multipart/source handling, generated request models, typed errors, public exports, import integrity, broader regeneration changes and compatibility. Trusted Python 3.14 AST parsing passed for 1,076 source files; 4,094 relative import targets had no missing targets.
Findings
No confirmed diff-scoped findings.
Verification and limits
Static source review and existing CI inspection. No PR code, native test suite, package build, browser flow, or live staging deployment was executed locally. Live custom-image acceptance remains dependent on compatible Hosting deployment and feature activation.
All reported CI checks passed at review completion. New deployment operations and schemas agree with Hosting. Diff whitespace checking reports generated-file whitespace; no correctness finding retained. Keep package release separate until compatible server support is deployed.
All four requested passes completed. Reviewed commit: 366aa1745018ef22aef8d5ad236228efbd4b3550.
2 participants
Expose custom Sandbox deploy, deployment status, retained source, regional build logs and template deletion through the public Python facade. Update the internal generated client, preserve multipart archive bytes, and accept canonical log regions.
Validation: native generation/type/unit/build/package checks and Hosting-owned installed-package binding inspection passed. Live custom deployment scenarios remain pending P8 server deployment and the staging custom-image flag. Merge the implementation before coordinated Hosting contract CI; publish a package release only after compatible server support is available.
Related changes:
Deploy the log-output producer first. Merge SDK implementations before coordinated Hosting contract validation; keep SDK package releases separate until compatible server support is deployed. Staging activation #1666 is merged.