Repository navigation
feat: renew distributed lock leases - #62
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4f92f4429f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return FakeResponse( | ||
| 200, | ||
| {"expires_at": "2026-08-26T12:01:00Z", "fencing_token": 8}, |
There was a problem hiding this comment.
Model a successful renewal with fencing token 7, not 8. The ProjectLockLease contract in openapi/openapi.yaml states that this token stays unchanged across renewals and rises only when the lock changes hands; this fixture and its assertion currently bless the opposite behavior, so a future renewal implementation that incorrectly advances fencing epochs could still pass the facade test.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in 8b6c400. Both facade and generated-transport fixtures now enforce fencing token 7 before and after renewal, matching the OpenAPI invariant.
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Adds
client.locks.renew(key, lease, ttl=...)and returns a new immutable lease.renewProjectLockoperationVerification: OpenAPI provenance, Ruff, mypy, Pyright, 261 unit tests, contract dry-run, package build, and Hosting SDK contract guards.