[Issue-2721] Extension - Fix bug show withdraw time (Round 2)#4846
Open
tunghp2002 wants to merge 5 commits into
Open
[Issue-2721] Extension - Fix bug show withdraw time (Round 2)#4846tunghp2002 wants to merge 5 commits into
tunghp2002 wants to merge 5 commits into
Conversation
This was
linked to
issues
Nov 14, 2025
|
🚀 Deployed on https://pr-4846--sw-web-runner.netlify.app |
bluezdot
force-pushed
the
koni/dev/issue-2721
branch
from
68de0ae to
b841302
Compare
bluezdot
requested changes
Nov 14, 2025
| const remainingTimeHr = remainingTimestampMs / 1000 / 60 / 60; | ||
|
|
||
| // Formatted waitting time without round up | ||
| // Example of _formattedWaitingTime: ... |
| @@ -45,9 +45,9 @@ export function getWaitingTime (t: TFunction, currentTimestampMs: number, target | |||
| } else { | |||
| const remainingTimeHr = remainingTimestampMs / 1000 / 60 / 60; | |||
There was a problem hiding this comment.
Create
const MS_PER_HOUR = 60 * 60 * 1000; // 3600000
| // Example of _formattedWaitingTime: ... | ||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-call,@typescript-eslint/no-unsafe-assignment | ||
| const _formattedWaitingTime = humanizeDuration(remainingTimestampMs, { | ||
| const _formattedWaitingTime = humanizeDuration(82799000, { |
| // eslint-disable-next-line @typescript-eslint/no-unsafe-call,@typescript-eslint/no-unsafe-assignment | ||
| const _formattedWaitingTime = humanizeDuration(remainingTimestampMs, { | ||
| const _formattedWaitingTime = humanizeDuration(82799000, { | ||
| units: remainingTimeHr >= 24 ? ['d', 'h'] : ['h', 'm'], |
There was a problem hiding this comment.
Remove remainingTimeHr and update condition
remainingTimeHr >= 24
=>
remainingTimestampMs >= MS_PER_HOUR
tunghp2002
force-pushed
the
koni/dev/issue-2721
branch
from
f0e6c17 to
fc4eafe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.