Skip to content

[Issue: 4768] Support Nested NFT Standard#4847

Open
frenkie-ng wants to merge 6 commits into
koni/dev/issue-4568from
koni/dev/issue-4768v1
Open

[Issue: 4768] Support Nested NFT Standard#4847
frenkie-ng wants to merge 6 commits into
koni/dev/issue-4568from
koni/dev/issue-4768v1

Conversation

@frenkie-ng

@frenkie-ng frenkie-ng commented Nov 14, 2025

Copy link
Copy Markdown

Overview

This PR introduces the new architecture for the NFT feature, where most logic is gradually moved from the extension to the SDK.
The goal is to simplify the extension codebase, improve maintainability, and prepare for upcoming NFT types (e.g., nested NFTs).


What's Included

  • Added the new structure/pattern for the NFT service.
  • Extension now only:
    • Sends requests to the SDK to fetch/update NFT data.
    • Updates local state with the returned result.
  • Separated flows for:
    • Cron job: auto-detect collections and preview NFTs.
    • UI-trigger action: fetch and update full NFT data.

Why This Change?

  • Current NFT logic is fragmented and hard to maintain.
  • Centralizing logic inside the SDK improves consistency and reusability.
  • Reduces duplication of logic between chains/networks.
  • Provides a solid foundation for supporting future NFT types.

@frenkie-ng frenkie-ng changed the base branch from subwallet-dev to koni/dev/issue-4568 November 14, 2025 10:55
…ue-4768v1

# Conflicts:
#	packages/extension-base/package.json
#	yarn.lock
…ev/issue-4768v1

# Conflicts:
#	packages/extension-base/src/services/nft-service/index.ts
@frenkie-ng frenkie-ng self-assigned this Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant