Skip to content

[Issue-151-Ex] Prioritize Hydration provider for swap #4853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bluezdot wants to merge 3 commits into
base: subwallet-dev
Choose a base branch
from
Open

[Issue-151-Ex] Prioritize Hydration provider for swap #4853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f42c6a
[Issue-4791] chores: comment affected scope to the improvement
bluezdot Nov 19, 2025
19acbea
[Issue-4791] chores: config backend url
bluezdot Nov 20, 2025
bfe4eba
[Issue-4791] chores: update be url
bluezdot Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .env.pull-request.development
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
SUBWALLET_API=https://be-dev-05.subwallet.app/api
1 change: 1 addition & 0 deletions packages/extension-base/src/koni/background/handlers/Extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4655,6 +4655,7 @@ export default class KoniExtension {
}

private async getLatestSwapQuote (swapRequest: SwapRequest): Promise<SwapQuoteResponse> {
// TODO (Issue-4791): this function must know previous picked quote to re-call that quote only.
const { swapQuoteResponse } = await this.#koniState.swapService.getLatestQuoteFromSwapRequest(swapRequest);

return swapQuoteResponse;
Expand Down
8 changes: 8 additions & 0 deletions packages/extension-base/src/services/swap-service/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,9 @@ export class SwapService implements StoppableServiceInterface {
* 4. Generate optimal process for that quote
* */

// TODO (Issue-4791): There are 2 ways:
// 1. find best quote and path, the logic here will remain same as before.
// 2. return all available (path, swapQuoteResponse). Need to update all affected uses of these two data.
const { path, swapQuoteResponse } = await this.getLatestQuoteFromSwapRequest(request);

console.group('Swap Logger');
Expand Down Expand Up @@ -207,6 +210,7 @@ export class SwapService implements StoppableServiceInterface {
let availablePath: SwapPath | undefined;

try {
// TODO (Issue-4791): findAvailablePath return SwapPath[] instead of SwapPath
availablePath = await subwalletApiSdk.swapApi.findAvailablePath(request);
} catch (e) {
console.log('Error findAvailablePath', e);
Expand Down Expand Up @@ -241,8 +245,12 @@ export class SwapService implements StoppableServiceInterface {
directSwapRequest.isCrossChain = true;
}

// TODO (Issue-4791): this function used to find all quotes and also the best quote of a path.
// In case we have many paths, we can also try finding best quote of all paths.
const swapQuoteResponse = await this.getLatestDirectQuotes(directSwapRequest);

// TODO (Issue-4791): return complex data include many (path, swapQuoteResponse) object.
// In fact, the current swapQuoteResponse included all quotes belong to the path.
return {
path,
swapQuoteResponse
Expand Down
Loading