feat: Added rendering of armor when using the custom first person

[RazorPlay01]

A new FirstPersonMode has been added which allows the rendering of armors when using the first person custom

I have preferred to do it this way and not add each shoulder separately to FirstPersonConfiguration because I doubt that anyone would be interested in handling the rendering of the shoulder pads separately, this way it will only be visible according to the arms if both are visible their respective armor parts will be shown instead when only one is visible only that one will show its armor.

[ZigyTheBird]

I think this would work better as a boolean in the FirstPersonConfiguration class rather than it's own first person mode, since I also plan to add my own first person mode and this would complicate things. (assuming my PR gets merged)
You can add a constructor to FirstPersonConfiguration without the new option for backwards compatibility.

[RazorPlay01]

It's not a bad option when I free up a little I do it now I have too much work :")

[ZigyTheBird]

Welp, I gave up on what I was trying to do... too hard :(

[ZigyTheBird]

I wanted to make a good way to have vanilla-style first person anims, rather than just rendering the third person model in first person.

[KosmX]

Is this new enum entry really necessary?

Wouldn't it be better to have the old entry (with updated comment) and use firstPersonConfig to optionally enable armor/shoulder rendering.

[RazorPlay01]

It is not strictly necessary as I had already arranged with zigby to modify it and do it through a boolean in FirstPersonConfiguration but I have not had time to implement it.

[RazorPlay01]

I just realized that you already did. I have been disconnected from this project too much work : “V

[KosmX]

i'll just push directly to your repo
(On PRs, the original author has access to push into the fork PR branch as long as the fork is on a personal account, and the PR author doesn't say otherwise)

[ZigyTheBird]

You should probably add a constructor to the first person configuration class with the original 4 booleans so mods don't break
Actually maybe write all the constructors by hand since that would be less confusing for beginners
Also I am looking for a fix to the lombok messing with the source code issue

[ZigyTheBird]

Hope this gets merged soon, I am almost done updating my API just waiting on these changes

[ZigyTheBird]

Maybe change the target branch to 1.21.4 and we can backport from there?

[RazorPlay01]

Yes, I don't see any problem to merge this

[ZigyTheBird]

@RazorPlay01 I need you to add this constructor to the FirstPersonConfiguration class:

    public FirstPersonConfiguration(boolean showRightArm, boolean showLeftArm, boolean showRightItem, boolean showLeftItem) {
        this.showRightArm = showRightArm;
        this.showLeftArm = showLeftArm;
        this.showRightItem = showRightItem;
        this.showLeftItem = showLeftItem;
    }

[ZigyTheBird]

Without it a lot of mods will break

[RazorPlay01]

If I had already done it, I think I hadn't updated my fork here.

[ZigyTheBird]

I made a build of this and sent it to a friend to test it to see if it works with stuff like GeckoLib armor
They should share the results here sometime soon

[ZigyTheBird]

If I had already done it, I think I hadn't updated my fork here.

Alright it's all good now, thanks :)

[RazorPlay01]

With geckolib it should not render anything, I already tried it at the time because this one uses another FeatureRenderer adapted to its models, I had planned to see how it worked well in the future to make it work but I have not had time for them

[ZigyTheBird]

Well that sucks.