Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Figura Item Pivot Compatibility #140

Open
wants to merge 1 commit into
base: 1.21
Choose a base branch
from
Open

Fix Figura Item Pivot Compatibility #140

wants to merge 1 commit into from

Conversation

klepticat
Copy link

Moved changeItemLocation from HeldItemMixin to ItemInHandRendererMixin so that the item pivot is animated even when Figura cancels renderArmWithItem.

2025-02-05_16-11-06_crop0.mp4

@ZigyTheBird
Copy link
Contributor

Notes for KosmX, ignore if you are the person who made this PR:
I think the ItemInHandRendererMixin should be moved outside of the first person folder now that it's required for other stuff
But I think it's odd that there is a folder for specifically first person related mixins in the first place

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klepticat @ZigyTheBird