feat: Generate stories from @Preview composables #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should have an api like |
congvc-dev
changed the title
|
this PR depends on #71 |
eymar
reviewed
May 14, 2025
| @@ -11,7 +11,7 @@ jobs: | |||
| uses: actions/setup-java@v2 | |||
| with: | |||
| distribution: 'adopt' | |||
| java-version: '17' | |||
| java-version: '21' | |||
There was a problem hiding this comment.
I don't know yet what exactly requires java 21 in this PR, but we need to stick to java 17 (should be compatible with java 17), because it's used in Compose repository.
There was a problem hiding this comment.
Based on this job, I suspect that my PR uses KSP 2.1.20-2.0.1 which was compiled with Java 21. Lowering KSP version perhaps the plausible option here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.