concatWithKeys impl #1107
Merged
concatWithKeys impl #1107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jolanrensen
approved these changes
Mar 25, 2025
| * Concatenates all groups in this [GroupBy] into a single [DataFrame], | ||
| * preserving and including all grouping key columns that are not present in the group's columns. | ||
| * | ||
| * Doesn't affect key columns that have the same names as columns inside the groups (even if their content differs). |
| @@ -40,6 +43,64 @@ public fun <T> DataFrame<T>.concat(frames: Iterable<DataFrame<T>>): DataFrame<T> | |||
|
|
|||
| public fun <T, G> GroupBy<T, G>.concat(): DataFrame<G> = groups.concat() | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Really nice and helpful kdoc :) Maybe something similar could be put on the documentation website?
There was a problem hiding this comment.
For sure, we will put it on website!
koperagen
reviewed
Mar 25, 2025
| @@ -6,49 +6,6 @@ | |||
| package org.jetbrains.kotlinx.dataframe.plugin | |||
|
|
|||
| import org.jetbrains.kotlin.fir.FirSession | |||
| import org.jetbrains.kotlinx.dataframe.plugin.extensions.KotlinTypeFacade | |||
There was a problem hiding this comment.
Can you revert this? It'll be easier for me to merge changes from DataFrame to Kotlin repo. I'll optimize imports there (and use start imports according to their codestyle)
koperagen
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #673.