Deprecate predicate argument in single, colsInGroups, colsAtAnyDepth #1176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koperagen
force-pushed
the
predicate-deprecation-1
branch
from
97204c3 to
5887f8b
Compare
koperagen
force-pushed
the
predicate-deprecation-1
branch
from
5887f8b to
a112e5e
Compare
Jolanrensen
requested changes
May 19, 2025
There was a problem hiding this comment.
Grammar DSL still contains predicates
There was a problem hiding this comment.
this is in all files I see, please try to rewrite those, and fix it in ColumnsSelectionDsl.kt as well. Let me know if you need help :)
| * | ||
| * `df.`[select][DataFrame.select]` { `[colsAtAnyDepth][ColumnsSelectionDsl.colsAtAnyDepth]` { !it.`[isColumnGroup][DataColumn.isColumnGroup]` } }` | ||
| */ | ||
| @Interpretable("ColsAtAnyDepth1") | ||
| @Deprecated("", replaceWith = ReplaceWith("colsAtAnyDepth().filter(predicate)")) |
There was a problem hiding this comment.
If you deprecate functions without const String in the deprecations file, we'll lose it and forget to remove it later
There was a problem hiding this comment.
grammer still has condition
| } | ||
| shouldThrow<IllegalArgumentException> { | ||
| df.select { single { true } } | ||
| df.select { cols().filter { true }.single() } |
There was a problem hiding this comment.
should be tested with df.select { single() } I believe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we discussed, predicate makes compiler plugin support of these functions unreliable. Deprecation suggests to use filter, updates some examples to use nameStartsWith