Util functions docs #1414
Merged
Util functions docs #1414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/util/deprecationMessages.kt
# Conflicts: # core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/util/deprecationMessages.kt
Jolanrensen
requested changes
Sep 4, 2025
Jolanrensen
reviewed
Sep 8, 2025
| val isHappy: Boolean | ||
| } | ||
|
|
||
| private val df = dataFrameOf( |
There was a problem hiding this comment.
btw, can these examples not all be moved into DataFrameSampleHelper? seems like a lot of duplication
There was a problem hiding this comment.
This caused by problems with plugin. When we solve them, we can reuse these DFs and schemas, but for now it doesn't work.
Jolanrensen
reviewed
Sep 8, 2025
| @@ -10,28 +10,6 @@ At the moment, these integrations are still part of the `:core` module: | |||
| - (deprecated) csv/tsv | |||
| - html | |||
|
|
|||
| ### Korro code samples | |||
There was a problem hiding this comment.
While they are still here, I'd keep the docs but mark that they are being moved to :samples, potentially linking an issue number. At the moment they are still here, right?
Jolanrensen
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs for functions from #1412 + a lot of improvements for docs.
Closes #1413.